chore: improve logging #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
force-pushed
the
improve-logs-v14
branch
from
35ed8b9 to
8ff4d05
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
shumkov
requested changes
Oct 28, 2023
Comment on lines
-90
to
-91
| "height", stateData.Height, | ||
| "round", stateData.Round, |
There was a problem hiding this comment.
Why did we remove height and round?
| @@ -395,10 +395,10 @@ func (blockExec *BlockExecutor) ValidateBlockWithRoundState( | |||
| // Validate app info | |||
| if uncommittedState.AppHash != nil && !bytes.Equal(block.AppHash, uncommittedState.AppHash) { | |||
| return fmt.Errorf( | |||
| "wrong Block.Header.AppHash at state height %d, block %d. Expected %X, got %X", | |||
| "Block.Header.AppHash mismatch; state (or ABCI App) at height %d expects App Hash %X, block at height %d expects App Hash %X", | |||
There was a problem hiding this comment.
From my perspective, the new message is more confusing than the previous one. What if we just swap app hash params and keep the old one?
6 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Logs are too verbose
What was done?
How Has This Been Tested?
Github Actions
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only